Re: [HACKERS] Interval aggregate regression failure

From: Michael Glaesemann <grzm(at)seespotcode(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Michael Paesold <mpaesold(at)gmx(dot)at>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Interval aggregate regression failure
Date: 2006-09-01 10:54:57
Message-ID: 4045BD1F-990D-4AF3-BC9C-698E30F88788@seespotcode.net
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers pgsql-patches


On Sep 1, 2006, at 11:31 , Bruce Momjian wrote:

> Tom Lane wrote:
>> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>>> I am unclear about this report. The patch was not meant to fix
>>> every
>>> interval issue, but merely to improve multiplication and division
>>> computations. Does it do that?
>>
>> According to Michael's last report, your patch fails under
>> --enable-integer-datetimes.
>
> Where does it fail? Here?
>
> select interval '41 mon 12 days 360:00' * 0.3 as product_a
> , interval '-41 mon -12 days +360:00' * 0.3 as product_b
> , interval '-41 mon 12 days 360:00' * 0.3 as product_c
> , interval '-41 mon -12 days -360:00' * 0.3 as product_d;
> product_a | product_b |
> product_c | product_d
> --------------------------+-----------------------------
> +----------------------------+---------------------------------
> 1 year 11 days 146:24:00 | -1 years -11 days +69:36:00 | -1 years -5
> days +98:24:00 | -1 years -11 days -146:23:60.00
> -----
>
> That is wrong, but I think we need another fix for that. Notice the
> problem is in minutes/seconds, not hours.

I was sure it was more wrong than that the first time I saw it, but
looks like I can't be sure of anything today :(. I need more sleep.
Sorry for the noise on this one.

Off work now, so I'm back at it.

Michael Glaesemann
grzm seespotcode net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Glaesemann 2006-09-01 11:01:22 Re: [HACKERS] Interval aggregate regression failure
Previous Message Zeugswetter Andreas DCP SD 2006-09-01 10:44:18 Re: Prepared statements considered harmful

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Glaesemann 2006-09-01 11:01:22 Re: [HACKERS] Interval aggregate regression failure
Previous Message Victor B. Wagner 2006-09-01 09:59:48 SSL enhancement patch ver.2