| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SKIP LOCKED assert triggered |
| Date: | 2022-01-04 16:15:30 |
| Message-ID: | 4030482.1641312930@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Pushed, thanks Simon for reporting this problem.
Umm ...
Assert(TM_WouldBlock || !(tuple->t_data->t_infomask & HEAP_XMAX_INVALID));
AFAICS, this assertion condition is constant-true,
because TM_WouldBlock is a nonzero constant. Perhaps you meant
Assert(result == TM_WouldBlock || !(tuple->t_data->t_infomask & HEAP_XMAX_INVALID));
?
I'd be inclined to format it more like the adjacent Assert, too.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-01-04 16:31:42 | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |
| Previous Message | Alvaro Herrera | 2022-01-04 16:13:23 | Re: SKIP LOCKED assert triggered |