Re: TAP testing for psql's tab completion code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: TAP testing for psql's tab completion code
Date: 2019-12-30 14:10:40
Message-ID: 4030.1577715040@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> Well, I think that where possible we ought to test using the existing
>> test infrastructure -- help, for example, seems like it could perfectly
>> well be tested in src/test/regress/sql/psql.sql, or we could move stuff
>> out to a new set of SQL test scripts under src/bin/psql/sql/,

> I do not think it is a good idea, because help output is quite large,
> there are many of them, and we should certainly not want it stored
> repeatedly in output files for diffs.

Hm, I don't follow --- we are most certainly not going to exercise
\help for every possible SQL keyword, that'd just be silly.

Having said that, the fact that \help now includes a version-dependent
URL in its output is probably enough to break the idea of testing it
with a conventional expected-output test, so maybe TAP is the only
way for that.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2019-12-30 14:39:10 Re: Disallow cancellation of waiting for synchronous replication
Previous Message Tom Lane 2019-12-30 14:05:24 Re: comment regarding double timestamps; and, infinite timestamps and NaN