Re: Buildfarm failures on woodlouse (in ecpg-check)

From: Christian Ullrich <chris(at)chrullrich(dot)net>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Buildfarm failures on woodlouse (in ecpg-check)
Date: 2017-06-12 05:53:40
Message-ID: 4023c0f2-420c-152e-8475-106114905c79@chrullrich.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Andrew Dunstan wrote:

> On 06/11/2017 11:33 AM, Christian Ullrich wrote:

>> To build correctly, it requires defining _WIN32_WINNT to be 0x600 or
>> above (and using an SDK that knows about InitOnceExecuteOnce()).

> We already define _WIN32_WINNT to be 0x0600 on all appropriate platforms
> (Vista/2008 and above), so I think you could probably just check for
> that value.

Not quite; the definition depends on the build toolset, not the build
platform. When building with VS 2015 and above, _WIN32_WINNT is set to
0x600 (Vista/2008), while with older compilers, the value is 0x501
(XP/2003). This is also due to locale issues, but of a different kind,
and is apparently coincidental.

The build platform does not figure into the target platform, which is
clearly a good idea for binary distribution reasons.

--
Christian

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2017-06-12 05:57:52 Re: documentation typo in ALTER TABLE example
Previous Message Amit Langote 2017-06-12 05:16:52 Re: documentation typo in ALTER TABLE example