Re: pgsql: Don't leave behind files in src dir in 007_multixact_conversion.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Don't leave behind files in src dir in 007_multixact_conversion.
Date: 2026-03-19 17:56:55
Message-ID: 400d1718-d0d8-4080-a51b-b59ef8b1c488@dunslane.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 2026-03-18 We 7:19 PM, Robert Haas wrote:
> On Tue, Mar 17, 2026 at 5:52 AM Heikki Linnakangas
> <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>> Don't leave behind files in src dir in 007_multixact_conversion.pl
>>
>> pg_upgrade test 007_multixact_conversion.pl was leaving files like
>> delete_old_cluster.sh in the source directory for VPATH and meson
>> builds. To fix, change the tmp_check directory before running the
>> test, like in the other pg_upgrade tests.
>>
>> Author: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
>> https://www.postgresql.org/message-id/TYRPR01MB121563A4DA8B2FE9A2ECB79F5F541A@TYRPR01MB12156.jpnprd01.prod.outlook.com
> Thank you both! I am VERY happy that someone finally tracked this
> down. This has been bugging me for a while, but I haven't had time to
> figure out why it was happening.

+1

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-03-19 18:25:34 pgsql: Avoid leaking duplicated file descriptors in corner cases.
Previous Message Nathan Bossart 2026-03-19 16:44:00 pgsql: Allow choosing specific grantors via GRANT/REVOKE ... GRANTED BY

Browse pgsql-hackers by date

  From Date Subject
Next Message 段坤仁 (刻韧) 2026-03-19 18:02:30 Bug in MultiXact replay compat logic for older minor version after crash-recovery
Previous Message Peter Geoghegan 2026-03-19 17:44:16 Re: index prefetching