| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: pgsql: libpq: Grease the protocol by default |
| Date: | 2026-02-24 18:50:33 |
| Message-ID: | 4004006.1771959033@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> So pg_upgrade will use max_protocol_version=3.0 with all servers v10
> and below, in practice. There's nothing wrong with that behavior, but
> I think I should switch to a simple `< 1100` check in the code to
> avoid misleading people, unless anyone has a better way that won't
> significantly increase the cost of the backport.
Simple is good here. I don't think we'd buy much by distinguishing
minor versions of already-EOL servers. Also, I suspect that
pg_upgrade can't get the minor version except by starting the server
and asking it --- we don't record anything but major version on-disk.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-02-24 18:58:30 | Re: pgsql: libpq: Grease the protocol by default |
| Previous Message | Jacob Champion | 2026-02-24 18:13:02 | Re: pgsql: libpq: Grease the protocol by default |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2026-02-24 18:52:00 | Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering |
| Previous Message | Zsolt Parragi | 2026-02-24 18:33:19 | Re: More speedups for tuple deformation |