Re: Bug in RI

From: Jeroen van Vianen <jeroen(dot)van(dot)vianen(at)satama(dot)com>
To: Stephan Szabo <sszabo(at)megazone23(dot)bigpanda(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Bug in RI
Date: 2000-09-22 08:08:12
Message-ID: 4.3.2.7.2.20000922095336.00abb1e0@ams010.satama.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 21:13 21-9-00 -0700, Stephan Szabo wrote:
>This is a one line patch that will throw a notice with
>what relation name it's trying to open and what it
>got back in RI_FKey_keyequal_upd. It should say
>the name of your table and a number, but I expect
>the number will be 0.

Yes, it is. So I also found the error: I did a rename table and the
constraint triggers were not updated with the new table name.

Maybe a little check should be built in to check for fkey == 0, like this
(from the top of my head, no actual checking):

fk_rel = heap_openr(tgargs[RI_FK_RELNAME_ARGNO], NoLock);
+ if (fk_rel == NULL) {
+ elog(ERROR, "In foreign key constraint, cannot open relname: %s",
+ tgargs[RI_FK_RELNAME_ARGNO]);
+ }
pk_rel = trigdata->tg_relation;
new_row = trigdata->tg_newtuple;
old_row = trigdata->tg_trigtuple;

Thanks for your help,

Jeroen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeroen van Vianen 2000-09-22 11:08:17 Patch for Bug in RI
Previous Message Tatsuo Ishii 2000-09-22 06:31:59 ecpg is broken in current