| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Subject: | Re: Allow a prosupport function to be attached to an aggregate |
| Date: | 2026-08-20 07:23:38 |
| Message-ID: | 3f63c035-e0a6-4dc6-a34e-743df8c19d50@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18/8/2026 16:35, Tom Lane wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> So I think it's a must-fix. To put my money where my mouth is,
> here's a draft patch. (I could not resist the temptation to
> improve compute_common_attribute's existing error message,
> which pretty well sucks: it's useless in a context that's not
> showing you an accurate error pointer.)
Thank you for the patch. I agree that it is the right shape for v19, so
I assembled it into a small series.
- 0001 documents SupportRequestSimplifyAggref. This is the patch I sent
earlier, unchanged.
- 0002 is your patch, plus documentation and regression tests.
The documentation there provides the rationale for why CREATE/ALTER
AGGREGATE should be added in v.20.
Also, I'm not sure why pg_dump/upgrade has not been implemented. So, I
added an 'unsupported' clause into the docs - let's discuss it later or
correct me if such a feature can't be supported at all.
--
regards, Andrei Lepikhov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Document-the-SupportRequestSimplifyAggref-support-re.patch | text/plain | 1.9 KB |
| 0002-Allow-a-planner-support-function-to-be-attached-to-a.patch | text/plain | 20.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-08-20 07:31:49 | Re: Logical replication row filter loses unchanged toasted columns |
| Previous Message | ZizhuanLiu X-MAN | 2026-08-20 07:18:38 | Re: [PATCH] Doc: Mention OFF as an alias for EXPLAIN SERIALIZE NONE |