| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without |
| Date: | 2010-02-01 10:36:59 |
| Message-ID: | 3f0b79eb1002010236g68009c3dmdaf8c985bcbbbc56@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Feb 1, 2010 at 7:27 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Fujii Masao wrote:
>> The cause of the problem seems to be the new heap created by
>> rebuild_relation() and copy_heap_data(), i.e., new VACUUM FULL.
>> Since it's not a temporary heap, its rd_istemp is off. OTOH
>> it needs to be synced after physical copy from old heap.
>
> Why does it need to be synced?
>
> ISTM the bug is that rd_istemp is off at that point.
Umm... ISTM that new heap needs to be synced before calling
swap_relation_files(), but, in the now, I'm not sure whether
it's really required or not. Sorry.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2010-02-01 10:38:44 | Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without |
| Previous Message | Heikki Linnakangas | 2010-02-01 10:30:43 | Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2010-02-01 10:38:44 | Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without |
| Previous Message | Rafael Martinez | 2010-02-01 10:33:56 | PITR - Bug or feature? |