Re: Backup history file should be replicated in Streaming Replication?

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Backup history file should be replicated in Streaming Replication?
Date: 2010-01-05 05:32:58
Message-ID: 3f0b79eb1001042132q44c14793if674f600ef085d67@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 4, 2010 at 9:55 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Heikki Linnakangas wrote:
>> Here's is modified patch that adds a new backupStartPoint field to
>> pg_control for that + some other minor editorialization.
>
> I've committed this now.

Thanks a lot!

src/backend/access/transam/xlog.c
> else
> {
> XLogRecPtr InvalidXLogRecPtr = {0, 0};
> ControlFile->minRecoveryPoint = InvalidXLogRecPtr;
> }

In my original patch, the above is for the problem discussed in
http://archives.postgresql.org/pgsql-hackers/2009-12/msg02039.php

Since you've already fixed the problem, that code is useless.
How about getting rid of that code?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message black light 2010-01-05 05:56:48 execute sql commands in core
Previous Message Tom Lane 2010-01-05 05:24:55 Re: pg_migrator issues