| From: | "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Robert Lor" <Robert(dot)Lor(at)sun(dot)com> |
| Cc: | "Bruce Momjian" <bruce(at)momjian(dot)us>, "pgsql-hackers list" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DTrace probes patch |
| Date: | 2008-12-17 02:15:17 |
| Message-ID: | 3f0b79eb0812161815y34842fafs282d781aae35e720@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Dec 17, 2008 at 4:53 AM, Robert Lor <Robert(dot)Lor(at)sun(dot)com> wrote:
> @@ -1313,12 +1318,14 @@ AdvanceXLInsertBuffer(bool new_segment)
> * Have to write buffers while holding insert
> lock. This is
> * not good, so only write as much as we
> absolutely must.
> */
> + TRACE_POSTGRESQL_WAL_BUFFER_WRITE_START();
> WriteRqst.Write = OldPageRqstPtr;
> WriteRqst.Flush.xlogid = 0;
> WriteRqst.Flush.xrecoff = 0;
> XLogWrite(WriteRqst, false, false);
> LWLockRelease(WALWriteLock);
> Insert->LogwrtResult = LogwrtResult;
> + TRACE_POSTGRESQL_WAL_BUFFER_WRITE_DONE();
Why is TRACE_POSTGRESQL_WAL_BUFFER_WRITE_START/DONE called
only in AdvanceXLInsertBuffer? We can trace only a part of WAL buffer write?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-12-17 02:18:36 | Re: Another issue in default-values patch: defaults expanded too soon |
| Previous Message | Robert Haas | 2008-12-17 01:57:47 | Re: Another issue in default-values patch: defaults expanded too soon |