For what should pg_stop_backup wait?

From: "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: For what should pg_stop_backup wait?
Date: 2008-08-07 12:11:27
Message-ID: 3f0b79eb0808070511n5cc3eb6eyaf98616aaacb0dda@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

In HEAD, pg_stop_backup waits until the history file has been archived.
But, in order to ensure that the last wal file was archived, pg_stop_backup
should wait until not only the history file but also the backup stopping wal
file has been archived, I think.

Because the alphabetic order of the history file and the backup stopping
wal file is not constant.

If the backup starting wal file is the same as the stopping one (that is,
any wal files were not switched during backup), the history file whose
name consists of the starting one is behind the stopping one.
Otherwise, the backup stopping wal file is behind the history file.

Is this worth fixing?

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2008-08-07 12:30:27 Re: Visibility Groups
Previous Message Robert Haas 2008-08-07 12:03:52 patch: Add columns via CREATE OR REPLACE VIEW