| From: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. |
| Date: | 2024-03-11 03:43:54 |
| Message-ID: | 3ed0590b-8132-482e-a9e6-bd694e4a48d7@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11.03.2024 03:39, Alexander Korotkov wrote:
> Now that we distinguish stats for checkpoints and
> restartpoints, we need to update the docs. Please, check the patch
> attached.
Maybe bring the pg_stat_get_checkpointer_buffers_written() description in consistent with these changes?
Like that:
--- a/src/include/catalog/pg_proc.dat
+++ b/src/include/catalog/pg_proc.dat
@@ -5740 +5740 @@
- descr => 'statistics: number of buffers written by the checkpointer',
+ descr => 'statistics: number of buffers written during checkpoints and restartpoints',
And after i took a fresh look at this patch i noticed a simple way to extract
write_time and sync_time counters for restartpoints too.
What do you think, is there a sense to do this?
With the best wishes,
--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-03-11 03:56:52 | Re: speed up a logical replica setup |
| Previous Message | Michael Paquier | 2024-03-11 03:33:42 | Re: Missing LWLock protection in pgstat_reset_replslot() |