| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: mingw32 floating point diff |
| Date: | 2019-08-23 06:14:06 |
| Message-ID: | 3ebea88c-c052-32f1-652a-585a5afd2cfb@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-08-22 18:19, Tom Lane wrote:
> What I suggest doing is reducing extra_float_digits to -1 for this
> specific test. Changing the contents of circle_tbl seems like it'd have
> more consequences than we want, in particular there's no guarantee that
> we'd not hit similar issues in other tests if they're given different
> inputs.
I agree that reducing the output precision is better than adjusting the
code.
The circle.sql file already has SET extra_float_digits TO 0, and a few
other files have other settings with different values. Are we content
to use various numbers until it works in each case, or should we try to
use some consistency?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-08-23 06:19:24 | pg_checksums --help synopsis is quite long |
| Previous Message | Thomas Munro | 2019-08-23 06:03:40 | Re: POC: Cleaning up orphaned files using undo logs |