Re: WIP: BRIN multi-range indexes

On 02/06/2018 12:40 AM, Tom Lane wrote:
> Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>> Yeah, that's what I've been wondering about too. There's also this
>> comment in nabstime.h:
>
>> /*
>> * Although time_t generally is a long int on 64 bit systems, these two
>> * types must be 4 bytes, because that's what pg_type.h assumes. They
>> * should be yanked (long) before 2038 and be replaced by timestamp and
>> * interval.
>> */
>
>> But then why adding BRIN opclasses at all? And if adding them, why not
>> to test them? We all know how long deprecation takes, particularly for
>> data types.
>
> There was some pretty recent chatter about removing these types;
> IIRC Andres was annoyed about their lack of overflow checks.
>
> I would definitely vote against adding any BRIN support for these
> types, or indeed doing any work on them at all other than removal.
>

Works for me. Ripping out the two opclasses from the patch is trivial.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services