| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fixing MSVC's inability to detect elog(ERROR) does not return |
| Date: | 2025-09-30 05:24:49 |
| Message-ID: | 3df44c55-d943-4176-a5d1-ba59f3df2b52@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27.09.25 12:43, David Rowley wrote:
> On Wed, 17 Sept 2025 at 15:52, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> Updated patch attached. Thanks for the review.
>
> Now pushed and awaiting buildfarm feedback.
Cool, seems to work. I also tried it on CI by removing a few "silence
compiler warning" lines.
Quick follow-up: How about we rename pg_builtin_integer_constant_p to
pg_integer_constant_p, since it's not actually built-in? See attached
patch.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rename-pg_builtin_integer_constant_p-to-pg_integer_c.patch | text/plain | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | BharatDB | 2025-09-30 05:30:48 | Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL |
| Previous Message | Alena Vinter | 2025-09-30 05:22:08 | Re: Resetting recovery target parameters in pg_createsubscriber |