Re: DROP DATABASE is interruptible

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Evgeny Morozov <postgresql3(at)realityexists(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: DROP DATABASE is interruptible
Date: 2023-09-25 00:48:31
Message-ID: 3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed that this patch set introduced this pg_dump test:

On 12.07.23 03:59, Andres Freund wrote:
> + 'CREATE DATABASE invalid...' => {
> + create_order => 1,
> + create_sql => q(CREATE DATABASE invalid; UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'invalid'),
> + regexp => qr/^CREATE DATABASE invalid/m,
> + not_like => {
> + pg_dumpall_dbprivs => 1,
> + },
> + },

But the key "not_like" isn't used for anything by that test suite.
Maybe "unlike" was meant? But even then it would be useless because the
"like" key is empty, so there is nothing that "unlike" can subtract
from. Was there something expected from the mention of
"pg_dumpall_dbprivs"?

Perhaps it would be better to write out

like => {},

explicitly, with a comment, like some other tests are doing.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-25 00:56:22 Re: Doesn't pgstat_report_wal() handle the argument "force" incorrectly
Previous Message Michael Paquier 2023-09-25 00:00:51 Re: Fix bug in VACUUM and ANALYZE docs