Re: Fix bug in multixact Oldest*MXactId initialization and access

From: Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: Fix bug in multixact Oldest*MXactId initialization and access
Date: 2026-02-27 05:00:28
Message-ID: 3d7a2207-0e61-4d95-bc00-e5248956a32b@postgrespro.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

26.02.2026 23:44, Sami Imseih пишет:
>> (Sorry, I've used Google Translate to write this sentence).
>>
>> When you write assert, you protect yourself from shooting your leg far in
>> the future. Believe me.
>
> The issue to me seems that we a few code paths that rely on the
> total proc calculation in several places, and changing one and
> forgetting to change another is what broke things.

If there were asserts, then tests would have failed.
Period.

There would no the bug. There would no this discussion.
If only array bounds were checked with asserts.

--
regards
Yura Sokolov aka funny-falcon

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2026-02-27 05:14:31 Re: Adding locks statistics
Previous Message Corey Huinker 2026-02-27 04:50:19 Re: Defects with invalid stats data for expressions in extended stats