| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Paul Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Think-o in foreign key comments |
| Date: | 2022-12-07 16:11:52 |
| Message-ID: | 3c87f4db-560b-d9b7-77f4-bdb67e0d122b@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.12.22 05:59, Ian Lawrence Barwick wrote:
> 2022年12月3日(土) 7:19 Paul Jungwirth <pj(at)illuminatedcomputing(dot)com>:
>> I noticed a few places in the new foreign key code where a comment says
>> "the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
>> DELETE SET NULL/DEFAULT".
>>
>> These comments were added in d6f96ed94e7, "Allow specifying column list
>> for foreign key ON DELETE SET actions." Here is a patch to correct them.
>
> LGTM.
>
> I do notice the same patch adds the function "validateFkOnDeleteSetColumns"
> but the name in the comment preceding it is "validateFkActionSetColumns",
> might as well fix that the same time.
Committed with that addition and backpatched to PG15.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-12-07 16:15:31 | Re: Error-safe user functions |
| Previous Message | Tom Lane | 2022-12-07 16:06:16 | Re: Error-safe user functions |