| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (but not seq_tup_read) |
| Date: | 2020-02-07 13:09:48 |
| Message-ID: | 3bf2f7e8-dd2d-ace6-f2d7-c05aac472934@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/02/07 17:28, Kasahara Tatsuhito wrote:
> Hi,
>
> On Fri, Feb 7, 2020 at 5:02 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> BTW, commit 147e3722f7 causing the issue changed currtid_byreloid()
>> and currtid_byrelname() so that they also call table_beginscan().
>> I'm not sure what those functions are, but probably we should fix them
>> so that table_beginscan_tid() is called instead. Thought?
> +1, sorry, I overlooked it.
>
> Both functions are used to check whether a valid tid or not with a
> relation name (or oid),
> and both perform a tid scan internally.
> So, these functions should call table_beginscan_tid().
>
> Perhaps unnecessary, I will attach a patch.
Pushed! Thanks!
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexey Bashtanov | 2020-02-07 13:56:52 | control max length of parameter values logged |
| Previous Message | Etsuro Fujita | 2020-02-07 12:57:21 | Re: [HACKERS] advanced partition matching algorithm for partition-wise join |