Re: Shouldn't postgres_fdw report warning when it gives up getting result from foreign server?

On 2021/11/22 14:16, Bharath Rupireddy wrote:
>> BTW, we can hide the message "remote SQL command: .." in cancel request case,
>> but which would make the debug and troubleshooting harder.
>
> Yeah, let's not hide the message.

Yes!

> For a cancel request maybe we can just say without te errcontext:
> ereport(WARNING,
> (errmsg("could not get result of cancel
> request due to timeout")));
>
> See the below existing message using "cancel request":
> errmsg("could not send cancel request: %s",
>
> For SQL command we can say:
> ereport(WARNING,
> (errmsg("could not get query result due to
> timeout"),
> query ? errcontext("remote SQL command:
> %s", query) : 0));

I wonder how pgfdw_get_cleanup_result() can determine which
log message to report. Probably we can add new boolean argument
to pgfdw_get_cleanup_result() so that it should be set to true
for cancel request case, but false for query case. Then
pgfdw_get_cleanup_result() can decide wihch message to log
based on that argument. But it seems not good design to me.
Thought?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION