Re: [GENERAL] Permission Denied Error on pg_xlog/RECOVERYXLOG file

From: David Steele <david(at)pgmasters(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeffrey(dot)Marshall(at)usitc(dot)gov, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] Permission Denied Error on pg_xlog/RECOVERYXLOG file
Date: 2016-06-03 21:41:35
Message-ID: 3b4f0328-648a-0f7d-19dc-ae7830349043@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On 6/3/16 4:13 PM, Robert Haas wrote:
> On Fri, Jun 3, 2016 at 2:12 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> On 2016-06-03 14:00:00 -0400, Robert Haas wrote:
>>> On Fri, May 27, 2016 at 8:44 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>>>> I'm not convinced of that. Hiding unexpected issues for longer, just to
>>>> continue kind-of-operating, can make the impact of problems a lot worse,
>>>> and it makes it very hard to actually learn about the issues.
>>>
>>> So if we made this a WARNING rather than an ERROR, it wouldn't hiding
>>> the issue, but it would be less likely to break things that worked
>>> before. No?
>>
>> Except that we're then accepting the (proven!) potential for data
>> loss. We're talking about a single report of an restore_command setting
>> odd permissions. Which can easily be fixed.
>
> Well, I think that having restore_command start failing after a minor
> release update can cause data loss, too. Or even an outage.

I'm mostly with Andres on this but you do make a good point, Robert.

Andres, what if on EPERM you set write privs on the file and retry?
Maybe only back patch that change and for 9.6 expect restore_command
scripts to set sane permissions.

--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-general by date

  From Date Subject
Next Message David G. Johnston 2016-06-03 21:51:09 Re: Partitioned postgres tables don't need update trigger??
Previous Message rverghese 2016-06-03 21:03:13 Partitioned postgres tables don't need update trigger??

Browse pgsql-hackers by date

  From Date Subject
Next Message Jean-Pierre Pelletier 2016-06-03 22:00:36 Number of parentheses in check constraints affected by operator_precedence_warning
Previous Message Michael Paquier 2016-06-03 21:32:08 Re: PostmasterPid not marked with PGDLLIMPORT