| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIP: Covering + unique indexes. |
| Date: | 2018-04-19 05:47:22 |
| Message-ID: | 3b0791a7-dc4f-ea93-bc38-b14b1803ca3a@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you, pushed.
> Actually, I see one tiny issue with extra '*' characters here:
>
>> + * The number of attributes won't be explicitly represented if the
>> + * negative infinity tuple was generated during a page split that
>> + * occurred with a version of Postgres before v11. There must be a
>> + * problem when there is an explicit representation that is
>> + * non-zero, * or when there is no explicit representation and the
>> + * tuple is * evidently not a pre-pg_upgrade tuple.
>
> I also suggest fixing this indentation before commit:
>
>> + /*
>> + *Cannot leak memory here, TupleDescCopy() doesn't allocate any
>> + * inner structure, so, plain pfree() should clean all allocated memory
>> + */
fixed
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2018-04-19 06:08:13 | Re: Problem while updating a foreign table pointing to a partitioned table on foreign server |
| Previous Message | Tsunakawa, Takayuki | 2018-04-19 05:45:12 | RE: Speedup of relation deletes during recovery |