| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Trial fix for old cross-version upgrades. |
| Date: | 2025-02-28 19:48:41 |
| Message-ID: | 3ac2cb7b-d0a7-4954-9e7a-97853d855df0@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2025-02-28 Fr 2:29 PM, Sami Imseih wrote:
> My perl expertise is bit shallow, but I could not find much
> regarding bugs related to such behavior, or maybe I did not
> look enough.
>
> Playing around with this, "s+", "s{1,}", s{2,}" all of these combinations
> where we are searching for more than 1 space result in the hanging command,
> but we really only need to look for a single space before the 'version',
> so maybe we can just do the below, which works?
>
> - $dump =~ s {(^\s+'version',) '\d+'::integer,$}
> + $dump =~ s {(^\s{1}'version',) '\d+'::integer,$}
>
Just noting here that \s{1} is simply the same as \s
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-02-28 19:53:19 | Re: pgsql: Trial fix for old cross-version upgrades. |
| Previous Message | Andrew Dunstan | 2025-02-28 19:46:58 | Re: pgsql: Refactor COPY FROM to use format callback functions. |