Skip site navigation (1) Skip section navigation (2)

Re: Problem with dblink

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>,Andrea Grassi <andreagrassi(at)sogeasoft(dot)com>, Darko(dot)Prenosil(at)finteh(dot)hr,shridhar_daithankar(at)persistent(dot)co(dot)in
Subject: Re: Problem with dblink
Date: 2003-11-26 20:46:30
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Tom Lane wrote:
> Looks right to me; but as a general tip, if you've made mistake X in
> place A, you might have made it in place B too.  Have you checked the
> rest of dblink for forgotten SPI_finish calls?

That function was the only one using SPI calls in dblink, so there were 
no others. Fix applied to head, 7.3 stable, and 7.4 stable.

> (More generally, I wonder if AtEOXact_SPI oughtn't be fixed to emit
> a WARNING if the SPI stack isn't empty, except in the error case.
> Neglecting SPI_finish is analogous to a resource leak, and we have
> code in place to warn about other sorts of leaks.)

I'll look at this separately. Changes in this regard only belong applied 
to cvs head I assume.


In response to


pgsql-patches by date

Next:From: Tom LaneDate: 2003-11-26 21:24:36
Subject: Re: Problem with dblink
Previous:From: Serguei MokhovDate: 2003-11-26 15:59:32
Subject: Re: postgress-ru.po - further translation

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group