Tom Lane wrote:
> Looks right to me; but as a general tip, if you've made mistake X in
> place A, you might have made it in place B too. Have you checked the
> rest of dblink for forgotten SPI_finish calls?
That function was the only one using SPI calls in dblink, so there were
no others. Fix applied to head, 7.3 stable, and 7.4 stable.
> (More generally, I wonder if AtEOXact_SPI oughtn't be fixed to emit
> a WARNING if the SPI stack isn't empty, except in the error case.
> Neglecting SPI_finish is analogous to a resource leak, and we have
> code in place to warn about other sorts of leaks.)
I'll look at this separately. Changes in this regard only belong applied
to cvs head I assume.
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2003-11-26 21:24:36|
|Subject: Re: Problem with dblink |
|Previous:||From: Serguei Mokhov||Date: 2003-11-26 15:59:32|
|Subject: Re: postgress-ru.po - further translation|