| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Andrea Grassi <andreagrassi(at)sogeasoft(dot)com>, Darko(dot)Prenosil(at)finteh(dot)hr, shridhar_daithankar(at)persistent(dot)co(dot)in |
| Subject: | Re: Problem with dblink |
| Date: | 2003-11-21 19:23:30 |
| Message-ID: | 23391.1069442610@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Joe Conway <mail(at)joeconway(dot)com> writes:
> Attached fixes a recently reported bug in dblink. If there are no
> objections, I'll make this my first commit :-)
Looks right to me; but as a general tip, if you've made mistake X in
place A, you might have made it in place B too. Have you checked the
rest of dblink for forgotten SPI_finish calls?
(More generally, I wonder if AtEOXact_SPI oughtn't be fixed to emit
a WARNING if the SPI stack isn't empty, except in the error case.
Neglecting SPI_finish is analogous to a resource leak, and we have
code in place to warn about other sorts of leaks.)
> I intend to apply it to HEAD and REL7_4_STABLE, but it could also be
> applied to REL7_3_STABLE -- any opinions on that? Are we still
> considering a 7.3.5 release?
Sure. I believe we still intend a 7.3.5 shortly (maybe early December,
since Thanksgiving week is a bad time to expect anything to happen).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2003-11-21 19:32:36 | Re: Problem with dblink |
| Previous Message | Joe Conway | 2003-11-21 18:24:48 | Re: Problem with dblink |