Re: pgsql: Add tests for tuplesort.c.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org,Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add tests for tuplesort.c.
Date: 2019-11-16 18:14:07
Message-ID: 3FC31FE3-18BE-40EF-84F1-EC4F7592F9E5@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On November 16, 2019 10:09:19 AM PST, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>On Wed, Nov 13, 2019 at 4:09 PM Andres Freund <andres(at)anarazel(dot)de>
>wrote:
>> Add tests for tuplesort.c.
>
>> Modified Files
>> --------------
>> src/test/regress/expected/tuplesort.out | 691
>++++++++++++++++++++++++++++++++
>> src/test/regress/parallel_schedule | 2 +-
>> src/test/regress/sql/tuplesort.sql | 304 ++++++++++++++
>> 3 files changed, 996 insertions(+), 1 deletion(-)
>
>Looks like you forgot to add an entry to serial_schedule.

Indeed, thanks for catching. I'm off till Monday... If you want to push the addition...

Really gotta change pg_regress to automatically serialize when setting max parallelism to 1...

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2019-11-16 18:40:17 Re: pgsql: Add tests for tuplesort.c.
Previous Message Peter Geoghegan 2019-11-16 18:09:19 Re: pgsql: Add tests for tuplesort.c.