Re: code coverage patch

From: Korry Douglas <korry(dot)douglas(at)enterprisedb(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Michelle Caisse <Michelle(dot)Caisse(at)sun(dot)com>
Subject: Re: code coverage patch
Date: 2008-08-28 13:08:46
Message-ID: 3F71903C-C784-4678-BDA7-32A46B2D9DFC@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> The problem with those files is that the source file contains lines
> like this:
>
> #line 1042 "y.tab.c"
>
> but that source file does not exist, as it is renamed to gram.c.
>
> We could fix that in one of two ways:
>
> 1) Use bison's -o option to put the output file in the right place
> directly,
> if we are dealing with bison (and don't bother to support code
> coverage
> analysis with other yaccs), or
>
> 2) Run a pattern replacement across the grammar output files as
> their are
> renamed.

Why not use the %output directive in the grammar file instead; that
way you don't need to add any special flags to the Makefile.

-- Korry

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2008-08-28 13:32:45 Re: code coverage patch
Previous Message Gregory Stark 2008-08-28 11:56:56 Re: code coverage patch