Re: [PATCHES] mcxt.c

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Postgresql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] mcxt.c
Date: 2003-09-09 15:33:03
Message-ID: 3F5DF2AF.50205@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera Munoz wrote:

>On Tue, Sep 09, 2003 at 04:53:06PM +0200, Gaetano Mendola wrote:
>
>
>>"Andrew Dunstan" <andrew(at)dunslane(dot)net> wrote:
>>
>>
>>>The particular assertion that was proposed doesn't strike me as terribly
>>>useful - It should be checked at the point of call rather than inside
>>>pstrdup, I should have thought.
>>>
>>>
>>Are you going to trust the client of that function ?
>>
>>
>
>Yes, because it can only used in backend code and C functions, which
>can be written only by a trusted user ('cause C is an untrusted language).
>
>(I might be wrong...)
>
>
>
Besides that, trust isn't the issue, but rather what useful information
can be gathered. How useful is it to know "someone called pstrdup() with
a null pointer"? Not very, IMNSHO.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-09-09 15:54:33 Re: plpgsql doesn't coerce boolean expressions to boolean
Previous Message Richard Hall 2003-09-09 15:27:24 Re: plpgsql doesn't coerce boolean expressions to boolean

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-09-09 17:53:26 Re: Minor lmgr code cleanup
Previous Message Alvaro Herrera Munoz 2003-09-09 15:14:57 Re: [PATCHES] mcxt.c