From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: libpq-win32 patches |
Date: | 2003-09-05 08:37:39 |
Message-ID: | 3F584B53.70500@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Hi Bruce,
>>
>>+
>>+/* getpwuid doesn't exist under win32 */
>>+#define getpwuid(uid) NULL
>>+
>> #endif /* pg_config_h_win32__ */
>>
>>
>
>Why was this needed? I realize we don't have getpwuid() on Win32, but
>we do have GetUserName() for cases where we need the name but not the
>directory.
>
>Because all the getpwuid() calls seem ifdef'ed out under Win32 anyway, I
>don't understand why you needed it.
>
I believe it was the first thing I did to have libpq compile at all.
Later, I went into the ssl code and made it work, effectively commenting
out all calls to getpwuid() making that line unnecessary.
>Can't we check the OS version via the compiler? Maybe not portabily
>between the various compilers supported.
>
>
If you're talking about the WIN32 macro, this should be supported by
every compiler running for win32, because windows headers rely on this.
Regards,
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Pflug | 2003-09-05 09:06:37 | Re: IPV4 addresses on IPV6 machines in pg_hba.conf |
Previous Message | Andriy Tkachuk | 2003-09-05 08:05:57 | Re: doc patch - linux memory handling |