From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] statement level trigger causes pltcl, plpython |
Date: | 2003-08-04 19:46:43 |
Message-ID: | 3F2EB823.50509@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> BTW, one other stylistic nit: I don't think comments like
>
> /* internal error */
> elog(ERROR, "unrecognized OP tg_event: %u", tdata->tg_event);
>
> are really necessary. In the brave new ereport world, any elog(ERROR)
> call is an internal error by definition --- if it isn't, you should be
> using ereport. So the use of elog is sufficient documentation. IMHO
> anyway.
Yeah, I agree. During the conversion, I did that mostly to show that it
was a conscious decision. Going forward, every new elog (versus ereport)
*is* a conscious decision, or at least should be.
Joe
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-08-04 20:12:17 | Re: Passing server_encoding to the client is not future-proof |
Previous Message | Alvaro Herrera | 2003-08-04 19:35:58 | Re: problem with cache |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-08-04 21:00:21 | Re: Patch for select() -> poll() in libpq |
Previous Message | Tom Lane | 2003-08-04 18:43:23 | Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV |