Re: connectby(... pos_of_sibling)

From: Joe Conway <mail(at)joeconway(dot)com>
To: Nabil Sayegh <postgresql(at)e-trolley(dot)de>
Cc: pgsql-novice <pgsql-novice(at)postgresql(dot)org>
Subject: Re: connectby(... pos_of_sibling)
Date: 2003-06-22 00:09:55
Message-ID: 3EF4F3D3.6070606@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-novice pgsql-patches

Nabil Sayegh wrote:
> For example (if the pos column is harcoded):
>
> The line:
> --------------------8<------------------------------------------------
> appendStringInfo(sql, "SELECT %s, %s FROM %s WHERE %s = '%s' AND %s
> IS NOT NULL ORDER BY pos",
> --------------------8<------------------------------------------------
> has to be changed
>
> build_tuplestore_recursively should get a static counter which should be
> incremented and stored with each tuple.
>
> Shouldn't that be all ?

Sounds like all that's needed for your case. But to be complete, in
addition to changing tablefunc.c we'd have to:
1) come up with a new function call signature that makes sense and does
not cause backward compatibility problems for other people
2) make needed changes to tablefunc.sql.in
3) adjust the README.tablefunc appropriately
4) adjust the regression test for new functionality
5) be sure we don't break any of the old cases

If you want to submit a complete patch, it would be gratefully accepted
-- for review at least ;-)

Otherwise, I'll see what I can do between now and the 7.4 feature freeze
(July 1), but as I said, no promises.

Joe

In response to

Responses

Browse pgsql-novice by date

  From Date Subject
Next Message Nabil Sayegh 2003-06-22 01:00:52 Re: connectby(... pos_of_sibling)
Previous Message Nabil Sayegh 2003-06-21 23:20:49 Re: connectby(... pos_of_sibling)

Browse pgsql-patches by date

  From Date Subject
Next Message Rod Taylor 2003-06-22 00:36:27 typo in arch-dev.sgml
Previous Message Nabil Sayegh 2003-06-21 23:20:49 Re: connectby(... pos_of_sibling)