| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Portal->commandTag as an enum |
| Date: | 2020-03-02 17:17:29 |
| Message-ID: | 3EBECD98-44BD-44B2-9035-3C59B59D6A2B@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 2, 2020, at 9:08 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2020-Mar-02, Alvaro Herrera wrote:
>
>> Here's the patch I propose for commit. I also rewrote the commit
>> message.
>
> BTW I wonder if we should really change the definition of
> EventTriggerData. ISTM that it would be sensible to keep it the same
> for now ...
I think it is more natural to change event trigger code to reason natively about CommandTags rather than continuing to reason about strings. The conversion back-and-forth between the enum and the string representation serves no useful purpose that I can see. But I understand if you are just trying to have the patch change fewer parts of the code, and if you feel more comfortable about reverting that part of the patch, as the committer, I think that's your prerogative.
Did you want to do that yourself, or have me do it and resubmit?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2020-03-02 17:24:57 | Re: [PATCH] Erase the distinctClause if the result is unique by definition |
| Previous Message | Alvaro Herrera | 2020-03-02 17:08:29 | Re: Portal->commandTag as an enum |