Re: GUC patch for Win32

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: GUC patch for Win32
Date: 2003-05-08 17:30:58
Message-ID: 3EBA9452.E09A231B@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
>
> Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> > Tom Lane wrote:
> >> On second thought, that just moves the race condition upstream (to the
> >> person editing postgresql.conf) ... so never mind that idea.
>
> > I didn't actually look at that part of the code yet ... why would any
> > backend read postgresql.conf?
>
> At SIGHUP, the postmaster re-reads postgresql.conf, and each backend
> must do so too --- there's no other way for pre-existing backends to
> learn about changed values. The assumption is that this happens over a
> short enough timespan that it's okay from the perspective of the person
> editing postgresql.conf. But if newly started backends were to read
> postgresql.conf when they start, that would be bad news for someone
> trying to edit postgresql.conf, because there'd be no way to know when
> it would happen.

Sure is there ... the way I did it originally.

The postmaster reads the config file and overrides with commandline
options. Then he dumps ALL options into a separate file.

A backend does not need to read the config file or parse commandline at
all. It just jeads the postmaster provided file.

If the user changes the config and HUP's the postmaster, postmaster
rereads the config and merges only those changes, that are changable at
runtime into it's status. From that status it creates the new file,
renames, HUP's the backends and they reread that file.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-05-08 17:49:57 Re: GUC patch for Win32
Previous Message Tom Lane 2003-05-08 15:49:41 Re: GUC patch for Win32