Re: Estimating HugePages Requirements?

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "magnus(at)hagander(dot)net" <magnus(at)hagander(dot)net>, "mark(dot)dilger(at)enterprisedb(dot)com" <mark(dot)dilger(at)enterprisedb(dot)com>, "don(at)seiler(dot)us" <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Estimating HugePages Requirements?
Date: 2021-09-21 00:08:22
Message-ID: 3E81D643-0759-4373-BEA6-5BF8818710BF@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin pgsql-hackers

Should we also initialize the shared memory GUCs in bootstrap and
single-user mode? I think I missed this in bd17880.

Nathan

diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend/bootstrap/bootstrap.c
index 48615c0ebc..4c4cf44871 100644
--- a/src/backend/bootstrap/bootstrap.c
+++ b/src/backend/bootstrap/bootstrap.c
@@ -324,6 +324,12 @@ BootstrapModeMain(int argc, char *argv[], bool check_only)

InitializeMaxBackends();

+ /*
+ * Initialize runtime-computed GUCs that depend on the amount of shared
+ * memory required.
+ */
+ InitializeShmemGUCs();
+
CreateSharedMemoryAndSemaphores();

/*
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
index 0775abe35d..cae0b079b9 100644
--- a/src/backend/tcop/postgres.c
+++ b/src/backend/tcop/postgres.c
@@ -3978,6 +3978,12 @@ PostgresSingleUserMain(int argc, char *argv[],
/* Initialize MaxBackends */
InitializeMaxBackends();

+ /*
+ * Initialize runtime-computed GUCs that depend on the amount of shared
+ * memory required.
+ */
+ InitializeShmemGUCs();
+
CreateSharedMemoryAndSemaphores();

/*

In response to

Responses

Browse pgsql-admin by date

  From Date Subject
Next Message Michael Paquier 2021-09-21 01:48:11 Re: Estimating HugePages Requirements?
Previous Message Gokan Atmaca 2021-09-20 13:03:53 Re: PgBackRest custom compiled postgres server

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2021-09-21 00:08:28 Re: postgres.h included from relcache.h - but removing it breaks pg_upgrade
Previous Message Jacob Champion 2021-09-21 00:06:15 Re: Support for NSS as a libpq TLS backend