| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Vlad Lesin <vladlesin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race |
| Date: | 2026-05-07 11:57:28 |
| Message-ID: | 3E582AB7-AE4B-45A0-8409-F42C81FD1F3E@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 7 May 2026, at 03:54, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> +#include "../injection_points/injection_point_condition.h"
>
> Hmm. I would not see a problem in just moving all that to the module
> injection_points instead, and keep it there, including your TAP test.
> Noah has done something similar for its removable_cutoff() business,
> and we are living well with it. One issue with the structure you are
> proposing is that I suspect that it makes some installcheck scenarios
> more iffy to deal with. More callbacks in the test module is fine.
Thanks, Michael!
Done so. I still keep Vlad's injection_point_condition.h though.
It seems useful. But no more Meson\Makefile changes, and new sql stuff lives
now near removable_cutoff() SQL.
Vlad, there are 2 patches in the patchset again :)
Now we need an expert in ProcKill(). I also will review the patchset in more detail,
but, perhaps, after pgconf.dev.
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| vAB3-0001-Add-regression-test-for-ProcKill-lock-group-pro.patch | application/octet-stream | 15.2 KB |
| vAB3-0002-Fix-ProcKill-lock-group-vs-procLatch-recycle-ra.patch | application/octet-stream | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2026-05-07 12:19:46 | Re: Include schema-qualified names in publication error messages. |
| Previous Message | Nisha Moond | 2026-05-07 11:53:58 | Re: Proposal: Conflict log history table for Logical Replication |