Re: pgsql-server/src/bin/pg_dump pg_backup_archiver.c

Tom Lane wrote:
>
> Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> writes:
> > Unfortunately I don't have an infinite time and it's
> > about time I give up the discussion. Feel free to revert
> > my change. It's useless unless it is committed to 7.3 tree
> > ASAP. I have little time this week anyway.
>
> I found that it's possible to modify the queries issued by FixupBlobRefs
> so that they work with the declarations created from either 7.2 or 7.3
> versions of contrib/lo. (Rather than assuming a cast exists, we can
> write the function call lo(oid) or oid(lo) instead.)
>
> This seems a much safer and more localized solution than having
> pg_restore try to update the function definitions and create casts.

I don't object to your solution. I can't expect anything
but the waste of my time for the discussion.

It seems the stupid bug about tar format check was fixed.
But I still see a failure when I call 7.3 pg_dump for
a 7.3 database and call 7.3 pg_restore for the data.
I see the following in the log.

CREATE CAST (public.lo AS oid) WITH FUNCTION oid (public.lo);
ERROR: parser: parse error at or near "." at character 117

regards,
Hiroshi Inoue
http://www.geocities.jp/inocchichichi/psqlodbc/