Re: array_cat anycompatible change is breaking xversion upgrade tests

> On 24 Jun 2022, at 18:30, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Fri, Jun 24, 2022 at 04:09:46PM +0500, Andrey Borodin wrote:
>> Hi everyone!
>>
>> Sorry for bumping old thread.
>
> Please find this newer thread+patch here ;)
> https://www.postgresql.org/message-id/20220614230949.GX29853@telsasoft.com

Oops. Let's discard my patch and I'll review yours. Many thanks for fixing this stuff :)

> On 24 Jun 2022, at 19:06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
>> I realized that my latest patch would break upgrades from old servers, which do
>> not have array_position/s nor width_bucket, so ::reprocedure would fail. Maybe
>> Andrey's way is better (checking proname rather than its OID).
>
> proname is dangerous, because there's nothing stopping users from
> adding more functions with the same name.
>
> Just use a server-version-dependent list of regprocedure OIDs.

Server-version-dependent list of oids seems more error prone. I think we can just check proname by the list and oid < 16384.

Thanks!

Best regards, Andrey Borodin.