| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: guc GetConfigOptionByNum and tablefunc API - minor changes |
| Date: | 2002-07-21 06:16:38 |
| Message-ID: | 3D3A51C6.3070308@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-patches |
Tom Lane wrote:
> Doesn't this duplicate get_func_rettype()? (Which is more clearly
> named anyway; a function's type is a second-order concept IMHO...)
Here's a second try at all three patches. I removed the foidGetTypeId()
function from funcapi.c, and replaced references to it in
contrib/tablefunc with get_func_rettype().
The only change to funcapi now is a minor addition to the comments in
funcapi.h and the funcapi doc for the previously mentioned undocumented
function.
As always, thanks for the review.
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| contrib_tablefunc.2002.07.20.2.patch | text/plain | 35.3 KB |
| guc_and_tablefunc_mod.2002.07.20.2.patch | text/plain | 3.0 KB |
| tablefunc_doc_mod.2002.07.20.2.patch | text/plain | 806 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2002-07-21 08:20:08 | pgsql/src/interfaces/ecpg/preproc preproc.y |
| Previous Message | Joe Conway | 2002-07-21 05:51:46 | Re: guc GetConfigOptionByNum and tablefunc API - minor changes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-07-21 13:46:08 | Re: guc GetConfigOptionByNum and tablefunc API - minor changes |
| Previous Message | Joe Conway | 2002-07-21 05:51:46 | Re: guc GetConfigOptionByNum and tablefunc API - minor changes |