| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Dave Cramer <davecramer(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-14 13:26:01 |
| Message-ID: | 3D275442-21FE-4B6D-8FBA-A080BB0D7488@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 13 Jul 2020, at 15:11, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
I took another look at the updated version today. Since there now were some
unused variables and (I believe) unnecessary checks (int size and endianness
etc) left, I took the liberty to fix those. I also fixed some markup in the
catalog docs, did some minor tidying up and ran pgindent on it.
The attached is a squash of the 4 patches in your email with the above fixes.
I'm again marking it RfC since I believe all concerns raised so far has been
addressed.
> Added the test case that Daniel had created.
Nope, still missing AFAICT =) But I've included it in the attached.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-binary-protocol-for-publications-and-subscriptio.patch | application/octet-stream | 47.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2020-07-14 13:32:09 | Re: Improvements in Copy From |
| Previous Message | vignesh C | 2020-07-14 13:22:58 | Re: [PATCH] Performance Improvement For Copy From Binary Files |