| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: invalid memory alloc request size error with commit 4b93f579 |
| Date: | 2018-02-27 01:25:12 |
| Message-ID: | 3D2300B9-2873-4ADC-9449-203D35E88137@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Feb 2018, at 05:25, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
>> I wonder whether it is worth creating a C trigger function
>> (probably in regress.c) specifically to exercise this situation.
>
> Actually, that doesn't seem too bad at all. I propose applying
> and back-patching the attached.
LGTM
> BTW, I noticed while doing this that the adjacent "funny_dup17"
> trigger is dead code, and has been since commit 1547ee01 of
> 1999-09-29. I'm inclined to rip it out, because anyone looking
> at regress.c would naturally assume that anything in there is
> being exercised.
+1, yes please. regress_dist_ptpath() and regress_path_dist() in regress.c
also seem to be dead, and have been so for.. quite some time.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Patrick Krecker | 2018-02-27 01:30:15 | Re: TODO item for broken \s with libedit seems fixed |
| Previous Message | Michael Paquier | 2018-02-27 01:24:41 | Re: BUG #14999: pg_rewind corrupts control file global/pg_control |