| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: SRF patch (was Re: [HACKERS] troubleshooting pointers) |
| Date: | 2002-05-19 20:55:42 |
| Message-ID: | 3CE8114E.2070400@joeconway.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> I am still concerned about whether ExecFunctionReScan works correctly;
> if not, the problems would show up in join and subquery situations.
> I think the parser and planner stages are in pretty good shape now,
> though. (At least as far as the basic functionality goes. Having
> a smarter materialization policy will take work in the planner.)
>
Here's a small patch to ExecFunctionReScan. It was clearing
scanstate->csstate.cstate.cs_ResultTupleSlot
when I think it should have been clearing
scanstate->csstate.css_ScanTupleSlot
although there is no discernable (at least to me) difference either way.
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| srf.2002.05.19.1.patch | text/plain | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Burton | 2002-05-19 21:00:54 | Exposed function to find table in schema search list? |
| Previous Message | Joe Conway | 2002-05-19 20:52:27 | Re: [PATCHES] SRF patch (was Re: troubleshooting pointers) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-05-19 21:22:34 | Re: [PATCHES] SRF patch (was Re: troubleshooting pointers) |
| Previous Message | Joe Conway | 2002-05-19 20:52:27 | Re: [PATCHES] SRF patch (was Re: troubleshooting pointers) |