| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Regression] Incorrect filename in test case comment |
| Date: | 2023-09-06 08:22:10 |
| Message-ID: | 3C6FDAB1-885A-48ED-B239-17C71EF8CE71@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Sep 2023, at 10:19, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
>> While browsing the test cases, found that the incorrect filename was there
>> in the test case comment.
>> The below commit added the custom hash opclass in insert.sql,
>
> --- part_part_test_int4_ops and part_test_text_ops in insert.sql.
> +-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.
>
> Good catch, but part_part_test_int4_ops should be renamed to
> part_test_int4_ops, removing the first "part_", no?
Ah, seems we came to same conclusion when looking simultaneously, I just pushed
the fix with the typo fix.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2023-09-06 08:37:20 | Re: Synchronizing slots from primary to standby |
| Previous Message | Daniel Gustafsson | 2023-09-06 08:21:07 | Re: [Regression] Incorrect filename in test case comment |