Re: GiST on 64-bit box

From: Teodor Sigaev <teodor(at)stack(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: GiST on 64-bit box
Date: 2002-02-08 17:23:40
Message-ID: 3C64099C.3080504@stack.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

My opinion is that second way is right (use GISTENTRY array). But this channge
requires changes in GiST API: picksplit and union functions must retrieve one
argument more. Is it possible to make for 7.2.1 or such changes must be appyed
in TODO for 7.3 ?

Tom Lane wrote:

> I think you have two possible ways to proceed:
>
> 1. Modify the code to use MAXALIGN(VARHDRSZ) rather than just VARHDRSZ
> as the offset in the bogus bytea construct. This would be messy since
> you couldn't use VARDATA() anymore.
>
> 2. Forget the bytea header and just treat the object as a GISTENTRY
> array.
>
> Either one of these is going to require changing the picksplit functions
> as well as the calling code, so they're both bad choices from a
> maintenance point of view. I think I lean towards #2 since it will make
> the code less ugly rather than more so.
>
> regards, tom lane
>
>

--
Teodor Sigaev
teodor(at)stack(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-02-08 17:28:41 Re: Summary of new configuration file and data directory locations
Previous Message Lee Kindness 2002-02-08 17:17:03 Re: IFNULL -> COALESCE