Re: [HACKERS] Re: WIN32 errno patch

From: Mikhail Terekhov <terekhov(at)emc(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Re: WIN32 errno patch
Date: 2001-08-17 19:21:48
Message-ID: 3B7D6ECC.A5D6570B@emc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Tom Lane wrote:
>
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I will try to apply it within the next 48 hours.
>
> This isn't the right patch to apply, since Mikhail didn't fix the
> strerror problem. I have some code from Magnus Naeslund that purports
> to handle the strerror issue, and will work it up into a patch real soon
> now.
>

As i've said in my other message this code doesn't solve the strerror
problem. I'd suggest to separate these two problems because
1. Without errno patch the code doesn't even compile,
but with errno patch the code compiles and works.
2. Without strerror patch we will have the same result as before,
i.e. error code but no error message. IMHO, it is impossible
to get winsock error messages without some system or version
dependent hack.

Regards,
Mikhail Terekhov

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Hiroshi Inoue 2001-08-17 23:50:01 pgsql/src/backend/catalog index.c
Previous Message Mikhail Terekhov 2001-08-17 18:51:59 Re: [HACKERS] Re: WIN32 errno patch

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruno Wolff III 2001-08-17 19:41:15 Re: PostgreSQL v7.1.3 bundled and uploaded to central FTP Server
Previous Message Mikhail Terekhov 2001-08-17 18:51:59 Re: [HACKERS] Re: WIN32 errno patch

Browse pgsql-patches by date

  From Date Subject
Next Message Liam Stewart 2001-08-17 19:59:38 DatabaseMetaData patch
Previous Message Mikhail Terekhov 2001-08-17 18:51:59 Re: [HACKERS] Re: WIN32 errno patch