Re: JDBC commit to 7.1.2

From: Barry Lind <barry(at)xythos(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL jdbc list <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: JDBC commit to 7.1.2
Date: 2001-05-22 19:10:47
Message-ID: 3B0AB9B7.2030802@xythos.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc pgsql-patches

The jdbc1 code does not have the problem that this patch corrects. So
no it does not need to be and should not be applied to the jdbc1 area.

I also noticed that that the original patch which was for the
jdbc2/ResultSet.java file was also applied to the jdbc1/ResultSet.java
file on the main trunk of the CVS. This will not work and that patch
needs to be removed from jdbc1/ResultSet.java. (The variable the patch
uses doesn't exist in the jdbc1 code thus the current jdbc1 code will
not compile).

The jdbc1 and jdbc2 sets of files are sufficiently different that
patches for one should not be applied to the other.

thanks,
--Barry

Bruce Momjian wrote:

> This timezone fix was applied to jdbc2 in 7.1.2 by Thomas. Do you want
> this in jdbc1 also? I am not recommending it, just asking to make sure
> it wasn't overlooked.
>
> ---------------------------------------------------------------------------
>
> revision 1.22.2.1
> date: 2001/05/22 14:46:46; author: thomas; state: Exp; lines: +4 -4
> Patch from Barry Lind to correctly decode time zones in timestamp results.
> Without patch, the time zone field is ignored and the returned time is
> not correct.
> Already applied to the development tree...
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-05-22 19:20:01 Re: JDBC commit to 7.1.2
Previous Message Bruce Momjian 2001-05-22 18:54:05 SEP_CHAR

Browse pgsql-jdbc by date

  From Date Subject
Next Message Bruce Momjian 2001-05-22 19:20:01 Re: JDBC commit to 7.1.2
Previous Message Bruce Momjian 2001-05-22 18:03:26 JDBC commit to 7.1.2

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-05-22 19:20:01 Re: JDBC commit to 7.1.2
Previous Message Bruce Momjian 2001-05-22 18:03:26 JDBC commit to 7.1.2