Re: [PATCHES] Re: microsecond log timestamps

From: Ed Loehr <eloehr(at)austin(dot)rr(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pggeneral <pgsql-general(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] Re: microsecond log timestamps
Date: 2001-05-13 15:35:28
Message-ID: 3AFEA9C0.8569F3A5@austin.rr.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-patches

Tom Lane wrote:
>
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > I am opposed to the unreadable, non-standard timestamp format.
>
> I didn't see the point of Ed's arbitrary change in YMD format, but
> what's wrong with adding fractional seconds? Our own timestamp code
> is willing to format fractional seconds, so we can hardly call it
> nonstandard.

Out of respect to existing log-processing programs, I tried to adhere to
the pgsql traditional (pre-7.1) format, except that I'd added a 4-digit
year I'd been patching since 6.5.2, which probably ended up breaking them
anyway.

> > I also don't see the point of microsecond granularity.
>
> What Ed implemented (which is what was in 7.0 and before) is millisecond
> resolution, which does seem worthwhile; certainly one-second resolution
> is pretty coarse on some machines these days.

Yes, microsecond was a typo. I meant milliseconds.

> I was thinking of keeping the YMD display format the same but otherwise
> adopting the patch.

That'd be an improvement. Unfortunately, the ISO 8601 standard is not
much more readable:

2001-05-13T10:19:44,085-05:00

That's a literal 'T' designating the time portion and a comma separating
seconds and milliseconds (http://www.iso.ch/markete/8601.pdf).

Regards,
Ed Loehr

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Simon Crute 2001-05-13 17:44:44 problems with timestamp fields
Previous Message Tom Lane 2001-05-13 15:27:45 Re: Bug with timestamp !!!

Browse pgsql-patches by date

  From Date Subject
Next Message Jason Tishler 2001-05-14 14:19:36 Re: PL/Python Postgresql 7.1.1 under Cygwin
Previous Message Tom Lane 2001-05-13 15:12:55 Re: [PATCHES] Re: microsecond log timestamps