| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Minor pg_amcheck fixes spotted while reading code |
| Date: | 2021-08-20 18:42:09 |
| Message-ID: | 3A6DD139-43F8-455D-BEE7-4D1CD0C013D3@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Aug 20, 2021, at 11:19 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> When perusing the pg_amcheck code the other day for the recently pushed fixes I
> found two small things that seem worth fixing: The help function progname
> parameter shadows the global variable of the same name, which no doubt will
> make static analyzers complain so we might as well fix that; and there is a
> tiny typo in the test stanza.
>
> Both fixed in the attached.
>
> --
> Daniel Gustafsson https://vmware.com/
>
> <0001-Fix-variable-shadowing.patch><0002-pg_amcheck-test-typofix.patch>
These look correct.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-08-20 18:56:43 | Re: Use extended statistics to estimate (Var op Var) clauses |
| Previous Message | Robert Haas | 2021-08-20 18:40:33 | Re: archive status ".ready" files may be created too early |