| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Small TAP improvements |
| Date: | 2022-06-14 16:44:09 |
| Message-ID: | 39c05f3f-9c7e-4411-b314-95c6a20f5543@www.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The comment atop config_data still mentions $option, but after the patch that's no longer a name used in the function. (I have to admit that using @_ in the body of the function was a little bit confusing to me at first. Did you do that in order to allow multiple options to be passed?)
Also: if you give an option to pg_config, the output is not prefixed with the variable name. So you don't need to strip the "SHAREDIR =" bit: there isn't any. This is true even if you give multiple options:
schmee: master 0$ pg_config --sharedir --includedir
/home/alvherre/Code/pgsql-install/REL9_6_STABLE/share
/home/alvherre/Code/pgsql-install/REL9_6_STABLE/include
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-06-14 17:14:15 | Re: Small TAP improvements |
| Previous Message | Tom Lane | 2022-06-14 16:26:05 | Re: better page-level checksums |