Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw
Date: 2026-02-18 20:30:06
Message-ID: 399150cb-a2ba-4405-a3d6-290d760b8d6c@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/18/26 9:23 PM, Etsuro Fujita wrote:
> I think the former part of the comment should be: Return *false* if
> the password_required is defined and false for this user mapping,
> otherwise *true*.
I feel the wording of the comment is pretty awkward both before and
after your correctness fix. I am not a native speaker but shouldn't it
be something like the below which explains better what is actually going on.

/*
* Checks the value of password_required, defaults to true
* if not defined. The mapping has been pre-validated.
*/

Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-02-18 21:23:28 Re: convert SpinLock* macros to static inline functions
Previous Message Jacob Champion 2026-02-18 20:27:56 Re: libpq: Bump protocol version to version 3.2 at least until the first/second beta